-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use torch APIs for ravel, tile, and outer tensorlib methods #1354
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1354 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 63 63
Lines 3768 3768
Branches 538 538
=======================================
Hits 3674 3674
Misses 55 55
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@lukasheinrich @kratsg let me know if you want this to go into a later release and not touch this now as it bumps up the minimum required release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a "lol" and "lgtm" here
Description
Resolves #1349
Adopt the
torch
API forravel
,tile
, andouter
for easier comparisons across backends as the PyTorchv1.8.0
release notes commentNote that in the case of
outer
thev1.8.0
docs note that fortorch.ger
(the current function)As a result also bump the minimum compatible release number of PyTorch to
1.8
so that these APIs exist.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: