Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Remove Jinja2 restrictions given nbconvert v6.4.5 #1837

Merged
merged 2 commits into from Apr 3, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Apr 3, 2022

Description

Revert PR #1824 given updates in nbconvert v6.4.5 (c.f. spatialaudio/nbsphinx#641 (comment)). The issues described there were resolved upstream of nbsphinx in jupyter/nbconvert#1737.

Resolves #1823

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Revert PR #1824 to remove restrictions placed on Jinja2 given
https://github.com/spatialaudio/nbsphinx/issues/641. The issues
described there were resolved upstream of nbsphinx in
https://github.com/jupyter/nbconvert/pull/1737.
   - Lower bounds of 'nbconvert>=6.4.5' are not added as lower
     bound restrictions should be applied upstream of pyhf in
     nbsphinx. PR #1824 was applied only because it was
     necessary.

@matthewfeickert matthewfeickert added docs Documentation related revert Reverts a previous commit labels Apr 3, 2022
@matthewfeickert matthewfeickert self-assigned this Apr 3, 2022
@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #1837 (d247e0b) into master (0693b9f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1837   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files          68       68           
  Lines        4315     4315           
  Branches      725      725           
=======================================
  Hits         4236     4236           
  Misses         46       46           
  Partials       33       33           
Flag Coverage Δ
contrib 26.44% <ø> (ø)
doctest 60.78% <ø> (ø)
unittests-3.10 96.03% <ø> (ø)
unittests-3.7 96.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0693b9f...d247e0b. Read the comment docs.

@matthewfeickert matthewfeickert added this to In progress in v0.7.0 via automation Apr 3, 2022
@matthewfeickert matthewfeickert merged commit ca12868 into master Apr 3, 2022
@matthewfeickert matthewfeickert deleted the docs/backoff-on-nb-restrictions branch April 3, 2022 22:43
v0.7.0 automation moved this from In progress to Done Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related revert Reverts a previous commit
Projects
Development

Successfully merging this pull request may close these issues.

Jinja2 v3.1.0 breaks nbsphinx
1 participant