Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add NumFOCUS Affiliated Project to README #2179

Merged
merged 3 commits into from Apr 8, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Apr 8, 2023

Description

Add the NumFOCUS Affilated Project badge to the README and mention in the Acknowledgements section.

NumFOCUS Affiliated Project

I don't think(?) there is an official badge given this discussion glotzerlab/signac#202 (comment) between @bdice and @csadorf (:wave:), but I like what they made so I'm going to copy signac. 👍

A note for posterity, pyhf became a NumFOCUS Affiliated Project on December 19th, 2022, but @matthewfeickert delayed a bit in getting a SVG version of the logo so it only got added to the project pages in April, 2022. But it is up now, and soon to be joined by https://github.com/scikit-hep/awkward who were accepted in the first round of 2023 applications!

(cc @cranmer)

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* pyhf became a NumFOCUS Affiliated Project on 2022-12-19.
   - c.f. https://numfocus.org/sponsored-projects/affiliated-projects
* Add mention of being a NumFOCUS Affiliated Project to the Acknowledgements
  section.

@matthewfeickert matthewfeickert added the docs Documentation related label Apr 8, 2023
@matthewfeickert matthewfeickert self-assigned this Apr 8, 2023
@matthewfeickert matthewfeickert changed the title docs: Add NumFOCUS Affiliated Projects badge to README docs: Add NumFOCUS Affiliated Project to README Apr 8, 2023
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ed8c920) 98.30% compared to head (5d1c197) 98.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2179   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4533     4533           
  Branches      801      801           
=======================================
  Hits         4456     4456           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.12% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.11 96.31% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit b46b3f0 into main Apr 8, 2023
20 checks passed
@matthewfeickert matthewfeickert deleted the docs/add-numfocus-affilated-badge branch April 8, 2023 19:38
matthewfeickert added a commit that referenced this pull request Apr 8, 2023
* Backport PR #2179
* pyhf became a NumFOCUS Affiliated Project on 2022-12-19.
   - c.f. https://numfocus.org/sponsored-projects/affiliated-projects
* Add mention of being a NumFOCUS Affiliated Project to the Acknowledgements
  section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant