Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove GKE mybinder build #2189

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Apr 27, 2023

Description

The GKE Binder Federation instance is being taken offline on 2023-04-28 and so requests made to gke.mybinder.org will fail. 😞 To keep the GHA workflow from failing remove the GKE build triggers.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* The GKE Binder Federation instance is being taken offline on
  2023-04-28 and so requests made to gke.mybinder.org will fail.
  To keep the GHA workflow from failing remove the GKE build triggers.
   - c.f. https://blog.jupyter.org/mybinder-org-reducing-capacity-c93ccfc6413f

* The GKE Binder Federation instance is being taken offline on
  2023-04-28 and so requests made to gke.mybinder.org will fail.
  To keep the GHA workflow from failing remove the GKE build triggers.
   - c.f. https://blog.jupyter.org/mybinder-org-reducing-capacity-c93ccfc6413f
@matthewfeickert matthewfeickert added Binder Contributing to having Binder build and Binder images run smoothly chore Other changes that don't modify src or test files need-to-backport tmp label until can be backported to patch release branch labels Apr 27, 2023
@matthewfeickert matthewfeickert self-assigned this Apr 27, 2023
@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3b68591) 98.30% compared to head (1f5d929) 98.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2189   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4533     4533           
  Branches      801      801           
=======================================
  Hits         4456     4456           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.12% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.11 96.31% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert merged commit b0e8f93 into main Apr 27, 2023
@matthewfeickert matthewfeickert deleted the chore/remove-gke-binder branch April 27, 2023 20:14
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label May 16, 2023
matthewfeickert added a commit that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Binder Contributing to having Binder build and Binder images run smoothly chore Other changes that don't modify src or test files
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant