Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Guard Minuit optimizer against provided strategy of None #2278

Merged
merged 9 commits into from
Aug 16, 2023
Merged

fix: Guard Minuit optimizer against provided strategy of None #2278

merged 9 commits into from
Aug 16, 2023

Commits on Aug 15, 2023

  1. refactor: Use int of truthiness to improve readability 

    * As the iminuit.Minuit.strategy is an integer, instead of having to
  have a human determine the integer representation of the inverse of
  the truthiness of do_grad during debugging or inspection do this in
  code.
    @matthewfeickert
    matthewfeickert committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    bc10ba4 View commit details
    Browse the repository at this point in the history

  2. test: Add strategy 2 to minuit optimizer tests

    @matthewfeickert
    matthewfeickert committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f634978 View commit details
    Browse the repository at this point in the history

  3. guard against Passing strategy=None to options

    @matthewfeickert
    matthewfeickert committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    dcabf32 View commit details
    Browse the repository at this point in the history

  4. Provide explenation of what None gives

    @matthewfeickert
    matthewfeickert committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    33d203a View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Update defintions of iMinuit strategies

    @matthewfeickert
    matthewfeickert committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    51a538a View commit details
    Browse the repository at this point in the history

  2. Clarify comment

    @matthewfeickert
    matthewfeickert committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    0cacda7 View commit details
    Browse the repository at this point in the history

  3. Simplify more

    @matthewfeickert
    matthewfeickert committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    73307a5 View commit details
    Browse the repository at this point in the history

  4. Clarify comment even more given new simplification

    @matthewfeickert
    matthewfeickert committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    6871bf1 View commit details
    Browse the repository at this point in the history

  5. Apply Alex's readability comment

    @matthewfeickert
    matthewfeickert committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    6cd5366 View commit details
    Browse the repository at this point in the history