Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Disallow TensorFlow v2.16.1 #2448

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 9, 2024

Description

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* tensorflow v2.16.1 breaks tensorflow-probability at import time with
  the Keras v3.0 API breaking change. Until Keras v3.0 is adopted in
  tensorflow-probability, tensorflow v2.16.1+ can't be used.
   - c.f. https://github.com/tensorflow/probability/issues/1795
* Note that Apple silicon machines should revert to installing
  'tensorflow' instead of 'tensorflow-macos' for tensorflow v2.16.1+.
* Note that macos x86 builds of tensorflow will be deprecated and no
  longer released from tensorflow v2.17.0+.

* tensorflow v2.16.1 breaks tensorflow-probability at import time with
  the Keras v3.0 API breaking change. Until Keras v3.0 is adopted in
  tensorflow-probability, tensorflow v2.16.1+ can't be used.
   - c.f. https://github.com/tensorflow/probability/issues/ 1795
* Note that Apple silicon machines should revert to installing
  'tensorflow' instead of 'tensorflow-macos' for tensorflow v2.16.1+.
* Note that macos x86 builds of tensorflow will be deprecated and no
  longer released from tensorflow v2.17.0+.
@matthewfeickert matthewfeickert added fix A bug fix build Changes that affect the build system or external dependencies need-to-backport tmp label until can be backported to patch release branch labels Mar 9, 2024
@matthewfeickert matthewfeickert self-assigned this Mar 9, 2024
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (975ee43) to head (de43628).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2448   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          69       69           
  Lines        4539     4539           
  Branches      803      803           
=======================================
  Hits         4461     4461           
  Misses         45       45           
  Partials       33       33           
Flag Coverage Δ
contrib 97.86% <ø> (ø)
doctest 98.14% <ø> (ø)
unittests-3.10 96.29% <ø> (ø)
unittests-3.11 96.29% <ø> (ø)
unittests-3.8 96.32% <ø> (ø)
unittests-3.9 96.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit af5d952 into main Mar 9, 2024
22 of 23 checks passed
@matthewfeickert matthewfeickert deleted the build/restrict-tensorflow branch March 9, 2024 07:45
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Mar 12, 2024
matthewfeickert added a commit that referenced this pull request Mar 12, 2024
…ion (#2452)

* Split the requirements for the 'tensorflow' extra into two different
  conditional groups by python_version.
   - Starting with tensorflow v2.16.1, multiple changes were made that simplifies
   the installation of tensorflow across platform_machine and Keras v3.0 was adopted.
   - tensorflow-probability did _not_ adopt Keras v3.0, but instead requires
   tf-keras. Starting in tensorflow-probability v0.24.0 the
   'tensorflow-probability[tf]' extra was added which includes all the required
   dependencies to be able to use tensorflow-probability with tensorflow v2.15+.
   - tensorflow v2.16.1 and tensorflow-probability v0.24.0 support Python 3.9+,
   so for Python 3.8 support the 'tensorflow' requirements need to use the
   previous more verbose conditionals.
* Reverts PR #2448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies fix A bug fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant