Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use lower bounds for all dependencies #2472

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Apr 27, 2024

Description

  • Loosen the install requirements for papermill, scrapbook, and sphinxcontrib-bibtex to use lower bounds instead of compatible release constraints.
  • Required for PR ci: Use uv for all pip installs #2444

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Loosen the install requirements for papermill, scrapbook, and
  sphinxcontrib-bibtex to use lower bounds instead of
  compatible release constraints.
* Required for PR https://github.com/scikit-hep/pyhf/pull/2444

* Loosen the install requirements for papermill, scrapbook, and
  sphinxcontrib-bibtex to use lower bounds instead of
  compatible release constraints.
* Required for PR https://github.com/scikit-hep/pyhf/pull/ 2444
@matthewfeickert matthewfeickert added build Changes that affect the build system or external dependencies chore Other changes that don't modify src or test files need-to-backport tmp label until can be backported to patch release branch labels Apr 27, 2024
@matthewfeickert matthewfeickert self-assigned this Apr 27, 2024
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (f561f86) to head (c7804e4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2472   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          69       69           
  Lines        4543     4543           
  Branches      804      804           
=======================================
  Hits         4462     4462           
  Misses         48       48           
  Partials       33       33           
Flag Coverage Δ
contrib 97.79% <ø> (ø)
doctest 98.08% <ø> (ø)
unittests-3.10 96.23% <ø> (ø)
unittests-3.11 96.23% <ø> (ø)
unittests-3.12 96.23% <ø> (ø)
unittests-3.8 96.25% <ø> (ø)
unittests-3.9 96.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit 682ce76 into main Apr 27, 2024
24 checks passed
@matthewfeickert matthewfeickert deleted the build/lower-bounds-on-papermill branch April 27, 2024 18:54
matthewfeickert added a commit that referenced this pull request May 30, 2024
* Backport:
   - PR #2443
   - PR #2446
   - PR #2451
   - PR #2458
   - PR #2460
   - PR #2465
   - PR #2468
   - PR #2471
   - PR #2472
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies chore Other changes that don't modify src or test files
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant