Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Don't test warnings on release tests #2489

Merged
merged 1 commit into from
May 29, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented May 29, 2024

Description

This follows up on a conversation with @alexander-held on better knowing if the latest releases are actually passing on new CPython versions. That being said, all the tests will fail currently given v0.7.6 happened before PR #2452 and so TensorFlow is breaking everything.

  • Override error on filterwarnings to avoid failing on warnings.
  • Set the fail-fast to False in the CI strategy to allow for identifying if things are OS specific.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Override error on filterwarnings to avoid failing on warnings.
* Set the fail-fast to False in the CI strategy to allow for identifying
  if things are OS specific.

* Override error on filterwarnings to avoid failing on warnings.
* Set the fail-fast to False in the CI strategy to allow for identifying
  if things are OS specific.
@matthewfeickert matthewfeickert added CI CI systems, GitHub Actions need-to-backport tmp label until can be backported to patch release branch labels May 29, 2024
@matthewfeickert matthewfeickert self-assigned this May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (a1d8476) to head (6af7ee9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2489   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          69       69           
  Lines        4543     4543           
  Branches      804      804           
=======================================
  Hits         4462     4462           
  Misses         48       48           
  Partials       33       33           
Flag Coverage Δ
contrib 97.79% <ø> (ø)
doctest 98.08% <ø> (ø)
unittests-3.10 96.23% <ø> (ø)
unittests-3.11 96.23% <ø> (ø)
unittests-3.12 96.23% <ø> (ø)
unittests-3.8 96.25% <ø> (ø)
unittests-3.9 96.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit 1af5ed4 into main May 29, 2024
25 of 33 checks passed
@matthewfeickert matthewfeickert deleted the ci/dont-test-deprecation-on-release branch May 29, 2024 16:55
@matthewfeickert
Copy link
Member Author

@meeseeksdev Hello

Copy link

lumberbot-app bot commented May 29, 2024

I'm Mr. Meeseek, @matthewfeickert, Look at meee !

@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label May 30, 2024
matthewfeickert added a commit that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant