Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backport): Use Python 3.12+ tarfile data extraction filter #2500

Conversation

meeseeksmachine
Copy link

@meeseeksmachine meeseeksmachine commented May 30, 2024

Backport PR #2455: feat: Use Python 3.12+ tarfile data extraction filter

* Backport PR https://github.com/scikit-hep/pyhf/pull/2455
* In Python 3.12 extraction filters are added and will become default in
  Python 3.14. To start using them for when Python 3.12 support is added, and
  to guard against a Python 3.14 DeprecationWarning, use the data extraction
  filter for extracting tarfiles in pyhf.contrib.utils.download.
   - c.f. https://docs.python.org/3.12/library/tarfile.html#extraction-filters

@lumberbot-app lumberbot-app bot added feat/enhancement New feature or request fix A bug fix contrib Targeting pyhf.contrib and not the core of pyhf need-to-backport tmp label until can be backported to patch release branch labels May 30, 2024
@matthewfeickert matthewfeickert changed the title Backport PR #2455 on branch release/v0.7.x (feat: Use Python 3.12+ tarfile data extraction filter) feat(backport): Use Python 3.12+ tarfile data extraction filter May 30, 2024
@matthewfeickert matthewfeickert added backport Backport PRs from main to release branch and removed need-to-backport tmp label until can be backported to patch release branch labels May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/v0.7.x@71b87eb). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/v0.7.x    #2500   +/-   ##
=================================================
  Coverage                  ?   98.19%           
=================================================
  Files                     ?       69           
  Lines                     ?     4547           
  Branches                  ?      804           
=================================================
  Hits                      ?     4465           
  Misses                    ?       49           
  Partials                  ?       33           
Flag Coverage Δ
contrib 97.73% <33.33%> (?)
doctest 98.02% <33.33%> (?)
unittests-3.10 96.19% <33.33%> (?)
unittests-3.11 96.19% <33.33%> (?)
unittests-3.12 96.19% <33.33%> (?)
unittests-3.7 96.17% <33.33%> (?)
unittests-3.8 96.21% <33.33%> (?)
unittests-3.9 96.23% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert self-assigned this May 30, 2024
@matthewfeickert matthewfeickert merged commit 88ba93b into scikit-hep:release/v0.7.x May 30, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport PRs from main to release branch contrib Targeting pyhf.contrib and not the core of pyhf feat/enhancement New feature or request fix A bug fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants