feat: Use 'method' arg for jax.numpy.percentile #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change the argument name in jax.numpy.percentile from 'interpolation' to 'method'.
No change to the lower bounds on jax and jaxlib is required as 'method' already
existed as an argument in jax v0.4.1. This just deprecates the use of 'interpolation'.
- Avoids the following DeprecationWarning in jax v0.4.29+:
DeprecationWarning: The interpolation= argument to 'percentile' is deprecated.
Use 'method=' instead.
- c.f. https://github.com/google/jax/pull/ 21267
matthewfeickert
added
feat/enhancement
matthewfeickert
removed
the
need-to-backport
|
@meeseeksdev backport to release/v0.7.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pyhf
that referenced
this pull request
Jun 20, 2024
matthewfeickert
added a commit
that referenced
this pull request
Jun 20, 2024
* Backport PR #2522. * Change the argument name in jax.numpy.percentile from 'interpolation' to 'method'. No change to the lower bounds on jax and jaxlib is required as 'method' already existed as an argument in jax v0.4.1. This just deprecates the use of 'interpolation'. Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
jax.numpy.percentilefrom'interpolation'to'method'. No change to the lower bounds onjaxandjaxlibis required as'method'already existed as an argument injaxv0.4.1. This just deprecates the use of'interpolation'.jaxv0.4.29+:The CI is failing given another
DeprecationWarningfixed in PR #2523.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: