New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flesh out base documentation with introduction/background/details #480
Conversation
do we have a way to preview the docs of a PR? I guess not but it might be useful (not sure if there is such a functionality in RTD) |
could develop staging with GH actions. |
Can you elaborate? You're saying have some sort of separate deploy area for visual inspection? Or am I totally lost? |
Basically, GH actions should let you deploy to some website on every PR (or at least, say, trigger some integratoin/webhook) and master is built with GH-pages. |
@kratsg First, the docs you made are freaking amazing. Really nice! 😃 I have 4 questions though:
``auxiliary measurement'' Doesn't work |
|
Builds can be (re)started manually here: https://readthedocs.org/projects/pyhf-staging/builds/ |
Hm. I hadn't noticed this as I've mostly been writing docstrings with one sentence per line. (I've noticed there are some edge cases in which this matters, but I don't have an example I can point you to.) Would you be open to the idea of at least starting a new line after each sentence? This makes it easier for me to focus on the sentence as an atomic chunck (but I also have softwrap on). |
trying ~\textrm{TeV} inside the original \( \) doesn't render TeV properly
'exected' -> 'expected'
Ok, but we really only have this week to get the docs out. We're on a short timeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM. Let's approve this and get it merged in.
We can discuss linebreaks and things later.
Description
This PR fleshes out our documentation so it is a little less bare-bones and gives people things to read and understand the history/background behind the project.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: