Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate from diana-hep GitHub org to scikit-hep #643

Merged
merged 7 commits into from Nov 20, 2019

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 20, 2019

Description

Migrate from the DIANA/HEP GitHub org to the Scikit-HEP org

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Replace all instances of diana-hep with scikit-hep

@matthewfeickert matthewfeickert added the chore Other changes that don't modify src or test files label Nov 20, 2019
@matthewfeickert matthewfeickert self-assigned this Nov 20, 2019
@kratsg
Copy link
Contributor

kratsg commented Nov 20, 2019

We lost:

  • CodeFactor
  • LGTM analysis
  • Semantic Pull Request

@matthewfeickert
Copy link
Member Author

We lost:

  • CodeFactor
  • LGTM analysis
  • Semantic Pull Request

CodeFactor and LGTM are back. They just needed time to update.

  • CodeFactor
  • Language grade: Python

What's the issue with Semantic Pull Request?

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #643 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #643   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files          42       42           
  Lines        2547     2547           
  Branches      345      345           
=======================================
  Hits         2418     2418           
  Misses         85       85           
  Partials       44       44
Flag Coverage Δ
#unittests 94.93% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/pyhf/utils.py 97.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 847866f...951a32e. Read the comment docs.

@matthewfeickert matthewfeickert marked this pull request as ready for review November 20, 2019 17:30
@matthewfeickert matthewfeickert merged commit d4857ea into master Nov 20, 2019
@matthewfeickert matthewfeickert deleted the chore/migrate-to-scikit-hep branch November 20, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants