Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MXNet backend #83

Merged
merged 10 commits into from
Feb 12, 2018
Merged

Add MXNet backend #83

merged 10 commits into from
Feb 12, 2018

Commits on Feb 10, 2018

  1. Add placeholder MXNet backend

    Add a placeholder file for the MXNet backend and partially fill it in.
    
    In addition also add mxnet to packages to pip install and add
    mxnet_backend to the list of backends to test.
    matthewfeickert committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    faac9eb View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2018

  1. Add MXNet backend stack() and concatenate()

    Other methods are added as well, but these are the two that were the
    most important
    matthewfeickert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    0e8b5e4 View commit details
    Browse the repository at this point in the history
  2. Add placeholder for outer()

    The current outer() function is highly suboptimal. However, until a
    better solution can be implimented in a more MXNet-centric style it will
    at least pass the tests. The Pull Request in which this commit exists
    should _NOT_ be merged in until outer() is updated with a better
    solution.
    matthewfeickert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    f540dde View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2018

  1. Use MXNet-centric implimentation of outer()

    Use the linear algebra functions of MXNet to provide a more clean
    implimenation of the outer product method, outer()
    matthewfeickert committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    bf92334 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9fd4d01 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e6326dd View commit details
    Browse the repository at this point in the history
  4. Use list indexing instead of extended iterable unpacking

    Extended iterable unpacking wasn't added until PEP 3132 and so isn't in
    Python 2, which is causing the Python 2.7 tests to fail. While this is
    annoying, it is probably worth still supporting Python 2.7 until the
    official Python 2 end of life date.
    
    c.f. https://www.python.org/dev/peps/pep-3132/
    matthewfeickert committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    03b3f77 View commit details
    Browse the repository at this point in the history
  5. Use Conda environment.yml for Binder

    To support the more complex systems of multiple backends a Conda
    environment.yml file is used instead of a pip requirements.txt file for
    use with Binder.
    
    c.f.
    https://mybinder.readthedocs.io/en/latest/sample_repos.html#conda-environment-with-environment-yml
    matthewfeickert committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    6fc5436 View commit details
    Browse the repository at this point in the history
  6. Have simple_broadcast() return a MXNet NDArray

    Additionally make a correction to outer().
    nd.broadcast_mul() is the correct function to use in this method.
    matthewfeickert committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    c0c7654 View commit details
    Browse the repository at this point in the history
  7. Add docstrings

    Add Google Style docstrings that should be compatible with Sphinx under
    certain themes, such as the Sphinx theme created by Read The Docs. For
    an example of what this would look like, see PyTorch's docs.
    
    c.f.:
      http://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html#example-google
      http://pytorch.org/docs/master/_modules/torch/distributions/bernoulli.html#Bernoulli
    matthewfeickert committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    e40a007 View commit details
    Browse the repository at this point in the history