fix: Disallow cloudpickle v1.5.0 in 'tensorflow' extra

[matthewfeickert]

Description

Resolves #913

This is a temporary fix to Issue #913, as the actual fix in TensorFlow Probability PR 993 won't be available in a PyPI release until TensorFlow Probability v0.11.0. By explicitly disallowing cloudpickle v1.5.0 this patch unblocks development.

Checklist Before Requesting Reviewer

• Tests are passing (Current release tests are incapable of passing on this PR)
• "WIP" removed from the title of the pull request
• Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

• Summarize commit messages into a comprehensive review of the PR

* Explicitly disallow cloudpickle v1.5.0 to avoid breaking TensorFlow Probability 
   - This is a temporary solution to unblock development, but should be removed once TensorFlow Probability v0.11 has been released
   - https://github.com/tensorflow/probability/issues/991
   - https://github.com/cloudpipe/cloudpickle/issues/390

[codecov]

Codecov Report

Merging #915 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #915   +/-   ##
=======================================
  Coverage   96.28%   96.29%           
=======================================
  Files          56       56           
  Lines        3180     3188    +8     
  Branches      438      438           
=======================================
+ Hits         3062     3070    +8     
  Misses         75       75           
  Partials       43       43           

Flag	Coverage Δ
#unittests	96.29% <100.00%> (+<0.01%)	⬆️

Impacted Files	Coverage Δ
src/pyhf/tensor/jax_backend.py	94.26% <100.00%> (+0.09%)	⬆️
src/pyhf/tensor/numpy_backend.py	98.26% <100.00%> (+0.03%)	⬆️
src/pyhf/tensor/pytorch_backend.py	98.03% <100.00%> (+0.03%)	⬆️
src/pyhf/tensor/tensorflow_backend.py	96.46% <100.00%> (+0.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a1f996...b6f1945. Read the comment docs.

[matthewfeickert]

This is needed before PR #914 can go in.

[github-actions]

I've queued this up. When it gets merged, I'll create a patch release from v0.4.3 → v0.4.4 which includes the following 11 change(s) [including this PR]:

fix: Disallow cloudpickle v1.5.0 in 'tensorflow' extra

feat: Add precision information to tensorlib backends

ci: Verify build backend is compliant with PEP 517 in publishing workflow

fix: make pytorch_backend use configured dtypes

ci: Separate linting from testing

fix: Update infer.mle docstrings to match SciPy v1.5.0

fix: Keep Sphinx at v3.0.X releases

fix: Explicitly avoid Sphinx v3.1.0 in 'docs' extra

ci: Use Python 3.8 in all steps of publishing distributions

docs: Add 1Lbb hepdata likelihood record

fix: Check if HEAD of origin/master is accessible from latest tag

If you make any more changes, you probably want to re-trigger me again by removing the bumpversion/patch label and then adding it back again.

[matthewfeickert]

As the current release tests are all breaking as a result of Issue #913, we're going to have to make a patch release from this PR unless we want to deal with the current release tests being broken until whenever TFP v0.11 comes out.

[lukasheinrich]

are we tracking this in an issue so we remember to roll this back if tfp updates?

[matthewfeickert]

are we tracking this in an issue so we remember to roll this back if tfp updates?

This is now detailed in Issue #916

[matthewfeickert]

In retrospect, this

pyhf/setup.py

Line 7 in 64dbce0

'cloudpickle!=1.5.0', # TODO: Temp patch until tfp v0.11

probably should have been

'cloudpickle<1.5.0'

as it is possible given their release history that cloudpickle could make a new release before TensorFlow Probability v0.11.0.