Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use Particle v0.14 for minimal compatible release #64

Merged
merged 1 commit into from Dec 17, 2020

Conversation

eduardo-rodrigues
Copy link
Member

Trivial update to latest series. Not that the updates will matter to you here, but no harm in using the latest and greatest.
(In fact explicit support for Python 3.9 only came with the 0.13 series, so better update in any case.)

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #64 (8e67513) into master (51153ca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   62.80%   62.80%           
=======================================
  Files           1        1           
  Lines         164      164           
  Branches       32       32           
=======================================
  Hits          103      103           
  Misses         53       53           
  Partials        8        8           
Flag Coverage Δ
unittests 62.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51153ca...8e67513. Read the comment docs.

@matthewfeickert
Copy link
Member

matthewfeickert commented Dec 17, 2020

Trivial update to latest series. Not that the updates will matter to you here, but no harm in using the latest and greatest.
(In fact explicit support for Python 3.9 only came with the 0.13 series, so better update in any case.)

Thanks for the PR @eduardo-rodrigues. Note that with the compatible release syntax v0.14 is already being picked up with ~=0.12. Example:

$ docker run --rm -it python:3.8 /bin/bash
root@b53098b9144a:/# python -m pip install "particle~=0.12"
root@b53098b9144a:/# python -m pip list | grep particle
particle   0.14.0
root@b53098b9144a:/# python -m pip install --upgrade "particle~=0.12.0" # Here restricting to within the v0.12.X series
root@b53098b9144a:/# python -m pip list | grep particle
particle   0.12.0

So setting

particle~=0.12

is just requiring that pip have a lower bound of v0.12 and to be within the v0.X release series.

I agree there's no harm in merging this though.

@matthewfeickert matthewfeickert changed the title Update to Particle 0.14 series build: Use Particle v0.14 for minimal compatible release Dec 17, 2020
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@matthewfeickert matthewfeickert merged commit 5a78db5 into master Dec 17, 2020
@matthewfeickert matthewfeickert deleted the eduardo-particle-0.14 branch December 17, 2020 16:23
@eduardo-rodrigues
Copy link
Member Author

I see, thanks for pointing that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants