Use "entries" instead of "N" as arg name

[ndawe]

def tree2rec(tree, branches=None, entries=None, offset=0,                             
        include_weight=False,                                                   
        weight_name='weight',                                                   
        weight_dtype='f4'):

def tree2array(tree, branches=None, entries=None, offset=0,                           
        include_weight=False,                                                   
        weight_name='weight',                                                   
        weight_dtype='f4'):

@piti118 what do you think?

[piti118]

What is numpy using for their slicing methods? We better be consistent with them.

[piti118]

Actually I think you are right we'd better be consistent with root and call it entries.

You will need to change test method too.

[ndawe]

ROOT uses nentries and firstentry

[piti118]

And also do the same thing with root2rec and root2array

[ndawe]

right

[piti118]

nentries and firstentry seems overkill

[ndawe]

I agree. I prefer entries and offset

[ndawe]

Although offset isn't clear if it's inclusive or exclusive. firstentry is more clear.

[ndawe]

well... maybe it is clear...

[piti118]

I'm trying to find an equivalent in numpy they called number of bins in histograms bins

[piti118]

It'd be hard to fix it again let's be thorough

[piti118]

numpy use offset throughout http://docs.scipy.org/doc/numpy/reference/generated/numpy.ndarray.html

So, I think the best choice is offset and entries.

[ndawe]

Sounds good.

[piti118]

Do you want to implement this change?

[ndawe]

Sure, I'll submit a PR now.