This repository has been archived by the owner on Jan 7, 2023. It is now read-only.
check for inheritance in list_objects_recursive #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
following the check in [rootls](root-mirror/root/blob/master/main/python/cmdLineUtils.py#L186) check not only for exact class matches but also inheritance. This catches the corner cases of e.g. TNtupleD
| for t in types: | ||
| if cl.InheritsFrom(ROOT.gROOT.GetClass(t)): | ||
| objects.append(path + str(key.GetName())) | ||
| break |
There was a problem hiding this comment.
Why not something like:
if numpy.any([cl.InheritsFrom(ROOT.gROOT.GetClass(t)) for t in types])
|
Thanks for pointing this out. I've got a cython-level implementation in #249 |
| objects.append(path + str(key.GetName())) | ||
| cl = ROOT.gROOT.GetClass(clsname) | ||
| if types is None or\ | ||
| numpy.any([cl.InheritsFrom(ROOT.gROOT.GetClass(t)) for t in types]): |
There was a problem hiding this comment.
Best to avoid PyROOT stuff in the cython .pyx. The generated C++ code will be rather bulky and slow.
|
fine with me. then close this, and go for #249. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following the check in rootls, check not only for exact class matches but also inheritance.
This catches the corner cases of e.g. TNtupleD