-
Notifications
You must be signed in to change notification settings - Fork 35
Can't use formula as branch #14
Comments
Would you suggest that we silently ignore patterns that don't match and let root_numpy fail if it doesn't find something? It seems like we can't have both branch name matching and formulas in branch names, as the |
Indeed. I really like the globbing and brace expansion, so I'd be sad to see that go. Maybe if formulas had to be prefixed with some magic string? Like It's not ideal though, and would require explicit documentation (although the support for formula is isn't mentioned in the |
A Or there could just be a |
👍 for It's pretty obvious what |
root_numpy supports branch names to be formulas, such as 2*sqrt(x), which are parsed by ROOT’s TFormula class. The use of * by root_pandas for branch name matching conflicted with this behaviour. This commit adds the NOEXPAND_PREFIX string, which causes column names to skip the branch name matching mechanisms. Closes scikit-hep#14.
root_numpy supports branch names to be formulas, such as 2*sqrt(x), which are parsed by ROOT’s TFormula class. The use of * by root_pandas for branch name matching conflicted with this behaviour. This commit adds the NOEXPAND_PREFIX string, which causes column names to skip the branch name matching mechanisms. Closes scikit-hep#14.
root_numpy
supports using formula as branch names. For example:root_pandas
doesn't support this, because it pattern matches branch names, failing if a name in thebranches
argument doesn't match aTBranch
in theTTree
.The text was updated successfully, but these errors were encountered: