-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RNTuple split encoding tests #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but will let @jpivarski merge if happy since I suspect you're working in touch with him anyway.
I can't fix the problems this is having with pre-commit, nor even reproduce them. When I try to do pre-commit on my computer, I get a different error. In CI:
On my computer (Python 3.9):
But what's happening here is that we're checking in new data files with no changes to the code. The last code-change that I see in the codebase (not pre-commit version bumps, reformatting because of dropping Python 3.6, or added type annotations) are from April 16, 2021 (#51). That code is not breaking because it's not getting touched. I'm going to merge this because we need these new files in order to do Uproot testing. It might mean that pre-commit will be broken in main. I think we should scale back the testing that pre-commit is doing. |
To be checked indeed what changed in pre-commit. Unless we move straight to Ruff and the issue may go away since the hooks aren't all the same as far as I remember? Maybe a more pragmatic approach. WDYT @henryiii? |
The poetry error is due to isort using poetry-core, and poetry-core breaking them in 1.5 and them telling them it was their fault. All older versions of isort will not build from source anymore. We can update it, or move to Ruff, which can't exhibit this problem, as it has no dependencies and doesn't build from source. MyPy broke due to an update in a dependency I'd expect - maybe pytest. Should be an easy fix. |
Yes, something updates to start using Self from typing_extensions/Python 3.11, and that's only supported for mypy 1.0+. The root problem is pre-commit needs to be autoupdated (more often? At all?). |
No description provided.