Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update RNTuple files to RC2 #144

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

ariostas
Copy link
Collaborator

@ariostas ariostas commented Mar 6, 2024

I used a recent version of ROOT to regenerate the RNTuple files with the RC2 spec. I also removed the duplicate files uproot_ntuple_* that I mentioned in #143. I'll mark this as a draft for now since it should be merged alongside scikit-hep/uproot5#1115 so as to not break any CI workflows.

Closes #143

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.78%. Comparing base (daba9d1) to head (c6c2c5c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   69.78%   69.78%           
=======================================
  Files           3        3           
  Lines         139      139           
=======================================
  Hits           97       97           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpivarski
Copy link
Member

xxhash is not included in Pyodide, so making it a strict dependency in Uproot would prevent Uproot from being usable in JupyterLite.

image

Is the xxhash algorithm available in cramjam? If so, then we can absolutely depend on it in that way. Also, the cramjam authors have been very responsive to requests—they might be able to add it if it's not already included. (I assume it's a single function without dependencies.)

@ariostas
Copy link
Collaborator Author

ariostas commented Mar 7, 2024

I replied to your comment in scikit-hep/uproot5#1115 to continue the thread there.

@ariostas ariostas marked this pull request as ready for review March 21, 2024 15:15
@jpivarski
Copy link
Member

Merging this PR, which replaces the RNTuple files with the latest format, now that scikit-hep/uproot5#1115 is ready to use them. I'll make a release immediately afterward.

@jpivarski jpivarski merged commit 9ed1610 into scikit-hep:main Mar 21, 2024
8 checks passed
@ariostas ariostas deleted the update_rntuple_files branch April 17, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems like there are duplicate files
2 participants