-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually use Python 2.7 in win-py27 job #70
Conversation
Thanks for spotting the typo. CC @henryiii. |
This is not a typo! |
Oh, then it's better to add some code comment there... |
I did (in the revert PR). It's more obvious on the one above it, where all Python versions get built, I see that it could be a a little surprising on this one. I could leave off the number, I think GHA defaults to something more than 3.5, but I don't think they promise anything specific about the version you get by default, so I lock the version here. Maybe it would be cleaner/clearer though. If a runner defaulted to 2.7 I'd throw a fit... |
It looks like setup-python's default is |
The unknown Python version behavior they describe is if you don't call setup python, not if you call it with the default. :) |
No description provided.