Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use Python 2.7 in win-py27 job #70

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

webknjaz
Copy link
Contributor

No description provided.

@eduardo-rodrigues
Copy link
Member

Thanks for spotting the typo. CC @henryiii.

@eduardo-rodrigues eduardo-rodrigues merged commit 046f263 into scikit-hep:master Jul 27, 2020
@henryiii
Copy link
Member

This is not a typo! cibuildwheel can build any version of Python from any version of Python, but it requires the host to have 3.6+ to run. So this is now broken. Notice the other jobs build all the other versions of Python but only have a single host 3.7 Python. This is not different because it only runs one job.

henryiii added a commit that referenced this pull request Jul 27, 2020
henryiii added a commit that referenced this pull request Jul 27, 2020
@webknjaz
Copy link
Contributor Author

Oh, then it's better to add some code comment there...

@henryiii
Copy link
Member

henryiii commented Jul 27, 2020

I did (in the revert PR). It's more obvious on the one above it, where all Python versions get built, I see that it could be a a little surprising on this one. I could leave off the number, I think GHA defaults to something more than 3.5, but I don't think they promise anything specific about the version you get by default, so I lock the version here. Maybe it would be cleaner/clearer though.

If a runner defaulted to 2.7 I'd throw a fit...

@henryiii
Copy link
Member

It looks like setup-python's default is 3.x, which is the most recent Python supported. Since cibuildwheel is already being tested on 3.9-dev, I think we should be pretty safe in using the default even when it becomes 3.9 in the fall. I'll make a PR.

@henryiii
Copy link
Member

The unknown Python version behavior they describe is if you don't call setup python, not if you call it with the default. :)

henryiii added a commit that referenced this pull request Jul 27, 2020
henryiii added a commit that referenced this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants