Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Clean up of the TH write implementation #370

Merged
merged 1 commit into from
Oct 6, 2019
Merged

Clean up of the TH write implementation #370

merged 1 commit into from
Oct 6, 2019

Conversation

reikdas
Copy link
Collaborator

@reikdas reikdas commented Oct 6, 2019

Add underscore to indicate that TH attributes/methods are private

@reikdas reikdas requested a review from jpivarski October 6, 2019 03:09
jpivarski
jpivarski approved these changes Oct 6, 2019
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good—I remember suggesting this for consistency. All (or most) of these have tests, I assume, so the fact that the tests aren't broken means that none (or few) of the cases were missed.

Thanks!

@reikdas reikdas merged commit 7d11d3a into master Oct 6, 2019
@reikdas reikdas deleted the hist-cleanup branch October 6, 2019 13:46
@reikdas
Copy link
Collaborator Author

reikdas commented Oct 6, 2019

@jpivarski I have a release draft ready to go.

@jpivarski
Copy link
Member

Thanks! I published it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reikdas @jpivarski