Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to reading streamer and raise better error messages on true failures. #28

Merged

Conversation

jpivarski
Copy link
Member

@jpivarski jpivarski commented Jun 18, 2020

  • Reproduce the failure in demo-double32.root without trying to read Double32. (Just load TTree metadata.)
  • Add breadcrumbs to know where we are in the deserialization process. (Perhaps in context.)
  • Create a new exception for deserialization failures and include the breadcrumbs in the message.
  • Ensure that it's possible to locally override the classes dict.
  • Catch that new exception in TKey.get and fallback to reading the streamer before actually giving up.
  • The demo-double32.root example should then work. That's the end: close PR and move on!

@jpivarski jpivarski self-assigned this Jun 18, 2020
@jpivarski jpivarski marked this pull request as ready for review June 18, 2020 16:37
@jpivarski jpivarski merged commit 53eba54 into master Jun 18, 2020
@jpivarski jpivarski deleted the jpivarski/fallback-to-read-streamer-and-better-error-message branch June 18, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Predefined classes are preventing "wrong" class/streamer versions from being read
1 participant