-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: strided interpretation for data with extra offsets #852
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I compared the last issue of the non-primitive dtypes being passed on to awkward in the test added by this PR with I tracked where the byte order changes. This happens in
For the test I added, in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only change (which we discussed on Zoom): hide the new (None, None)
elements of members
by determining _all_headers_prepended
once for each AsStridedObjects
in its __init__
, and then remove the (None, None)
from the AsStridedObjects._members
that it presents to the world (through the members
property).
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is much better. Previously, this logic was happening in AsDtype
, but now it's in AsStridedObjects
, and that's good because it can only affect this one subclass.
Everything looks ready to merge. Go ahead and do it when you're done with the git branch!
@@ -4,8 +4,6 @@ | |||
import uproot | |||
import skhep_testdata | |||
|
|||
ROOT = pytest.importorskip("ROOT") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, because the file already exists. This will allow the test to be tested on more systems. Thanks for catching this!
No description provided.