feat: have unknown type become float64 when in array context #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpivarski
approved these changes
Apr 5, 2023
Comment on lines
-721
to
+723
| content = content.to_NumpyArray() | ||
| content = content.to_NumpyArray(dtype=numpy.float64) |
There was a problem hiding this comment.
Since this line was already here (with a bug; dtype is required), it looks like my original intention was for EmptyArrays to be converted into NumpyArrays; they were just prevented from doing so because of the earlier check.
Co-authored-by: Jim Pivarski <jpivarski@users.noreply.github.com>
|
You have my approval here; this only needs the update from #871 to get merged in so that the test passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.