chore: remove Python 3.6 support
#251
Conversation
pyproject.toml
Outdated
| @@ -51,7 +50,7 @@ awkward = [ | |||
| ] | |||
| dev = [ | |||
| "awkward>=1.2", | |||
| 'numba>=0.50; python_version >= "3.6"', | |||
| 'numba>=0.50; python_version >= "3.7"', | |||
noxfile.py
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| import nox | |||
|
|
|||
| ALL_PYTHONS = ["3.6", "3.7", "3.8", "3.9", "3.10"] | |||
| ALL_PYTHONS = ["3.7", "3.8", "3.9", "3.10"] | |||
There was a problem hiding this comment.
Can we add 3.11 now, too? And 3.11-dev to the testing matrix? Awkward supports 3.11 now. Some of the dev dependencies will need to require <3.11.
There was a problem hiding this comment.
(Actually the 3.11 stuff can be added before 0.9 & this PR)
|
We can change pyupgrade to |
Saransh-cpp
force-pushed
the
remove-3.6
branch
from
6f7f565
to
640f3da
Compare
|
Is this check configured as "required" for the whole org, or can it be disabled for |
|
You probably have access to change this (try checking): go to Settings (gear icon), then Branches (left menu), then Set Protection Rules. Inside that, there's a start-typing-then-dropdown-menu for adding new requirements and a way to "X" out old requirements.
I did it already for this one (dropped Python 3.6 and added 3.10 and 3.11-dev). |
|
I don't have access to the Settings tab 😅 Thank you! |
|
You might have permissions now. Maybe. |
| @@ -15,7 +15,7 @@ keywords = [ | |||
| license = "BSD-3-Clause" | |||
| maintainers = [ {name = "The Scikit-HEP admins", email = "scikit-hep-admins@googlegroups.com"} ] | |||
| authors = [ {name = "Jim Pivarski, Henry Schreiner, Eduardo Rodrigues", email = "eduardo.rodrigues@cern.ch"} ] | |||
| requires-python = ">=3.6" | |||
| requires-python = ">=3.7" | |||
| dependencies = [ | |||
| 'importlib-metadata>=0.22; python_version < "3.8"', | |||
| "numpy>=1.13.3", | |||
There was a problem hiding this comment.
I think this is now higher; the first version to support 3.7 was newer than 1.13.3.
|
Could you update the isort hook: - repo: https://github.com/PyCQA/isort
rev: 5.10.1
hooks:
- id: isort
args: ["-a", "from __future__ import annotations"]Edit: NVM, I went ahead and added it. |
Codecov ReportBase: 80.87% // Head: 81.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
==========================================
+ Coverage 80.87% 81.04% +0.16%
==========================================
Files 96 96
Lines 10529 10623 +94
==========================================
+ Hits 8515 8609 +94
Misses 2014 2014
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Yes! Thank you! |
Fixes #250