zenodo-badge-sync #269
Merged
zenodo-badge-sync #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Saransh-cpp |
Saransh-cpp
requested changes
Oct 6, 2022
README.md
Outdated
| @@ -24,7 +24,7 @@ Main features of Vector: | |||
| - Pure Python with NumPy as its only dependency. This makes it easier to install. | |||
| - Vectors may be represented in a variety of coordinate systems: Cartesian, cylindrical, pseudorapidity, and any combination of these with time or proper time for Lorentz vectors. In all, there are 12 coordinate systems: {_x_-_y_ vs _ρ_-_φ_ in the azimuthal plane} × {_z_ vs _θ_ vs _η_ longitudinally} × {_t_ vs _τ_ temporally}. | |||
| - Uses names and conventions set by [ROOT](https://root.cern/)'s [TLorentzVector](https://root.cern.ch/doc/master/classTLorentzVector.html) and [Math::LorentzVector](https://root.cern.ch/doc/master/classROOT_1_1Math_1_1LorentzVector.html), as well as [scikit-hep/math](https://github.com/scikit-hep/scikit-hep/tree/master/skhep/math), [uproot-methods TLorentzVector](https://github.com/scikit-hep/uproot3-methods/blob/master/uproot3_methods/classes/TLorentzVector.py), [henryiii/hepvector](https://github.com/henryiii/hepvector), and [coffea.nanoevents.methods.vector](https://coffeateam.github.io/coffea/modules/coffea.nanoevents.methods.vector.html). | |||
| - Implemented on a variety of backends: | |||
| - **Implemented on a variety of backends:** | |||
There was a problem hiding this comment.
I meant un-bold-ing this on the website, like it is in the README.
There was a problem hiding this comment.
removed bold font in README.md in index.rst the issue was because of previous line "_" changed it.
| @@ -133,8 +133,8 @@ The API reference details the functionality of each ``class`` and ``function`` p | |||
| :target: https://pypi.org/project/vector/ | |||
| .. |Conda latest releasetatus| image:: https://img.shields.io/conda/vn/conda-forge/vector.svg | |||
| :target: https://github.com/conda-forge/vector-feedstock | |||
| .. |DOI| image:: https://zenodo.org/badge/DOI/10.5281/zenodo.5942083.svg | |||
| :target: https://doi.org/10.5281/zenodo.5942082 | |||
| .. |DOI| image:: https://zenodo.org/badge/DOI/10.5281/zenodo.7054478.svg | |||
There was a problem hiding this comment.
The badges on the website should be split into 2 lines, just as they are in the README!
There was a problem hiding this comment.
Did the splitting.
Codecov ReportBase: 81.04% // Head: 81.04% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=======================================
Coverage 81.04% 81.04%
=======================================
Files 96 96
Lines 10624 10624
=======================================
Hits 8610 8610
Misses 2014 2014 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Saransh-cpp
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#268 Added the new badge and changed the font of required line in README to bold.