Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: coordinate transformation functions with momentum names #424

Merged

Conversation

Saransh-cpp
Copy link
Collaborator

@Saransh-cpp Saransh-cpp commented Feb 19, 2024

Description

Fixes #168

  • add tests

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't any other open Pull Requests for the required change?
  • Does your submission pass pre-commit? ($ pre-commit run --all-files or $ nox -s lint)
  • Does your submission pass tests? ($ pytest or $ nox -s tests)
  • Does the documentation build with your changes? ($ cd docs; make clean; make html or $ nox -s docs)
  • Does your submission pass the doctests? ($ pytest --doctest-plus src/vector/ or $ nox -s doctests)

Before Merging

  • Summarize the commit messages into a brief review of the Pull request.

@Saransh-cpp Saransh-cpp marked this pull request as draft February 19, 2024 15:48
@Saransh-cpp Saransh-cpp changed the title feat: coordinate transformation functions with momentum names (WIP) feat: coordinate transformation functions with momentum names Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (4cec27d) 82.70% compared to head (11a13fc) 82.87%.

Files Patch % Lines
src/vector/_methods.py 75.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   82.70%   82.87%   +0.17%     
==========================================
  Files          96       96              
  Lines       11453    11533      +80     
==========================================
+ Hits         9472     9558      +86     
+ Misses       1981     1975       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saransh-cpp Saransh-cpp changed the title (WIP) feat: coordinate transformation functions with momentum names feat: coordinate transformation functions with momentum names Feb 20, 2024
@Saransh-cpp Saransh-cpp marked this pull request as ready for review February 20, 2024 12:49
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The problem with momentum names is that the temporal coordinate names are very overloaded: E, e, energy and M, m, mass. (I don't think we should have all combinations; there are a lot of combinations!)

If someone's using this in an environment that has tab-complete, that should help a lot. That's why it's good that the alias you chose is the fully spelled-out word: the lower-case single-letter will expand to that, at least.

@Saransh-cpp Saransh-cpp merged commit 8493623 into scikit-hep:main Feb 21, 2024
22 of 23 checks passed
@Saransh-cpp Saransh-cpp deleted the momentum-coordinate-transforms branch February 21, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need coordinate transformation functions with momentum names
2 participants