New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: momentum coords should not be repeated with generic coords in subclasses #438
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #438 +/- ##
==========================================
+ Coverage 86.27% 86.30% +0.02%
==========================================
Files 96 96
Lines 11139 11139
==========================================
+ Hits 9610 9613 +3
+ Misses 1529 1526 -3 ☔ View full report in Codecov by Sentry. |
Tagging @agoose77 here because I cannot request a review from you for some reason 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes! Yes, please fix this. In the code diff, I don't see an explicit test for this bug, which would be a good thing to do, to make sure it doesn't happen again.
The reason you can't tag @agoose77 as a reviewer is because he's not in the list of maintainers for this package.
Thanks! I noticed that vector in general does not test subclassing the awkward mixins, which is why a few bugs popped up as soon as coffea decided to inherit them. I'll add tests for this. |
Description
Closes #225
Taking an example of coffee subclasses:
Before this PR:
After this PR:
Kindly take a look at CONTRIBUTING.md.
Please describe the purpose of this pull request. Reference and link to any relevant issues or pull requests.
Checklist
$ pre-commit run --all-files
or$ nox -s lint
)$ pytest
or$ nox -s tests
)$ cd docs; make clean; make html
or$ nox -s docs
)$ pytest --doctest-plus src/vector/
or$ nox -s doctests
)Before Merging