Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure the --before command line argument is respected when generating weekly updates #7

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Feb 15, 2021

Current behavior seems to be not filtering at all for the before date.

The issue was encountered when trying to generate a weekly update for Feb 1st through the 7th.
python skimage_weekly_update.py --before 2021-02-08 --after 2021-02-01

but this was also including all issues/PRs up until the current date. After the modifications here, the report looks as expected.

current behavior was hardcoded to the current date
@pep8speaks
Copy link

Hello @grlee77! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 72:80: E501 line too long (80 > 79 characters)
Line 78:13: E128 continuation line under-indented for visual indent
Line 82:13: E128 continuation line under-indented for visual indent
Line 87:13: E128 continuation line under-indented for visual indent
Line 87:80: E501 line too long (86 > 79 characters)
Line 99:13: E128 continuation line under-indented for visual indent
Line 106:13: E128 continuation line under-indented for visual indent

@jni
Copy link
Member

jni commented Feb 15, 2021

Yeah that was my bad. 😬 Thanks for the fix!

@jni jni merged commit eb535a0 into scikit-image:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants