New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build the doc with CircleCI? #2269
Comments
I think there are pro and cons. Clearly, it will make our life easier for PR where new features with documentation are added because very often screenshots are not attached. On the other way, it will take time to setup and to maintain just because we don't have a hand on these servers and we will depend on them if them change anything in the configuration. For travis for example, we have to spend quite a lot of time to my taste to maintain configurations just because we do not always have the right versions or so. |
I agree, that would be a nice feature to have. Reasonable alternative is to enable Finally, we have to developed a process to remove old/stored artifacts (applicable both for AppVeyor, Travis or even our website). Currently, I have no ideas how to make this work. |
Whoa! There is one more neat bot -> rust-lang/cargo#3039 (comment) . This one can be triggered to automatically build and merge PRs. If we decide on this solution, I believe that it is not so hard to write a customized bot for our needs. |
We should also check in with @matthew-brett who has experimented with |
See the comments in #3483. |
I would like to revisit this issue. I can change the Azure Pipelines confugiration to build the docs and upload them to some cloud storage. Not sure if GitHub Terms of Use allow that, but some (potentially private) repository could be used for such purposes. To avoid building the docs for every PR, it is possible to set some filters in Azure, for example, based on the PR caption ( Any opinions on this implementation? |
closed by #4881 |
At the moment, when a change is made to the documentation, the persons who are reviewing the PR have to (or should :-)) fetch the corresponding branch and build the doc on their machine. We could maybe use CircleCI and configure it to build the doc, so that it would be possible to see the new doc online, without having to build it locally.
What do you think?
The text was updated successfully, but these errors were encountered: