Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out filter functions from peak finding in blob_dog, blob_log #2315

Open
jmetz opened this issue Sep 20, 2016 · 2 comments
Open

Separate out filter functions from peak finding in blob_dog, blob_log #2315

jmetz opened this issue Sep 20, 2016 · 2 comments

Comments

@jmetz
Copy link
Contributor

jmetz commented Sep 20, 2016

Description

It might be useful to have access to the "image cube" filter data generated in blob_log and blob_dog, plus separating the generation of these into dedicated functions could afford a more suitable level of modularity.

I would propose two new functions in the filters module, named e.g. scale_space_log and scale_space_dog or similar, and then calling these in the blob_dog and blob_log functions.

@bernwang
Copy link

Where is the filters modules should these new functions be? Should they be in an existing file or a new one?

@jmetz
Copy link
Contributor Author

jmetz commented Nov 16, 2016

My suggestion would be to have a scale_space.py file in filters - but I guess we should wait for a core dev to weigh in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants