Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor setup.py to use setup_requires #2958

Closed
stefanv opened this issue Feb 5, 2018 · 2 comments
Closed

Refactor setup.py to use setup_requires #2958

stefanv opened this issue Feb 5, 2018 · 2 comments
Labels
🤖 type: Infrastructure CI, packaging, tools and automation 🔧 type: Maintenance Refactoring and maintenance of internals
Milestone
0.16

Comments

@stefanv
Copy link
Member

stefanv commented Feb 5, 2018

Newer versions of setuptools support setup_requires, which we can use to ensure that NumPy is installed:

http://setuptools.readthedocs.io/en/latest/setuptools.html
@soupault soupault added the 🔧 type: Maintenance Refactoring and maintenance of internals label Feb 5, 2018
@soupault soupault added this to the 0.15 milestone Feb 5, 2018
@stefanv
Copy link
Member Author

stefanv commented Apr 19, 2018

Should rather use https://www.python.org/dev/peps/pep-0518/; see #3020

@stefanv stefanv changed the title Refacor setup.py to use setup_requires Refactor setup.py to use setup_requires Apr 19, 2018
@soupault soupault modified the milestones: 0.15, 0.16 Apr 20, 2019
@grlee77
Copy link
Contributor

grlee77 commented Apr 5, 2021

I am closing this since we are now using pyproject.toml which will pull in an appropriate NumPy

@grlee77 grlee77 closed this as completed Apr 5, 2021
@grlee77 grlee77 added the 🤖 type: Infrastructure CI, packaging, tools and automation label Apr 5, 2021
@grlee77 grlee77 mentioned this issue Apr 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 type: Infrastructure CI, packaging, tools and automation 🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Milestone
0.16
Development

No branches or pull requests
3 participants
@stefanv @soupault @grlee77