Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out building and uploading windows wheels to PyPI for releases #2986

Closed
jni opened this issue Mar 15, 2018 · 8 comments
Closed

Figure out building and uploading windows wheels to PyPI for releases #2986

jni opened this issue Mar 15, 2018 · 8 comments
Labels
🤖 type: Infrastructure CI, packaging, tools and automation 🔧 type: Maintenance Refactoring and maintenance of internals
Milestone

Comments

@jni
Copy link
Member

jni commented Mar 15, 2018

Installation on windows is not easy when not using conda, see e.g. #2942 #2985. We should figure out how to build release wheels e.g. on AppVeyor so that installing on Windows is easy after release and doesn't rely on a bunch of manual work by the release manager.

@jni
Copy link
Member Author

jni commented Mar 25, 2018

Here's what appears to be a useful link:

https://packaging.python.org/guides/supporting-windows-using-appveyor/#automatically-uploading-wheels

I would propose adding a twine upload step to the AppVeyor file when we tag a release. Ditto for Travis. I don't know how to manage the credentials and security though. Any suggestions?

@matthew-brett
Copy link
Contributor

You're already using the Rackspace credentials to upload there, for the Linux and macOS wheels, I'd recommend doing the same for the Windows wheels. I've found it very useful to have an intermediate gathering phase before uploading, in case a later wheel build breaks, perhaps requiring a code change. I can set up the Rackspace credentials if you like, for Appveyor. Example here : https://github.com/MacPython/nipy-wheels/blob/master/appveyor.yml

@matthew-brett
Copy link
Contributor

Also - did you see : scikit-image/scikit-image-wheels#3 ?

@hmaarrfk
Copy link
Member

hmaarrfk commented Aug 7, 2018

Wheels seem to be up on pypi. I guess from scikit-image/scikit-image-wheels#6 PR.

I guess we can close this?

@jni
Copy link
Member Author

jni commented Aug 7, 2018

@hmaarrfk the current wheels were uploaded manually. Ideally, releasing skimage should be reduced to tagging the right commit on GitHub. There is much work still to do.

@soupault soupault added the 🔧 type: Maintenance Refactoring and maintenance of internals label Aug 7, 2018
@soupault soupault added this to the 1.0 milestone Aug 7, 2018
@hmaarrfk
Copy link
Member

hmaarrfk commented Aug 7, 2018

Are OSX and Linux wheels uploaded automatically by travis?

@matthew-brett
Copy link
Contributor

I honestly don't think you should upload the wheels automatically. At the moment, I think you have the standard process used by numpy, scipy, matplotlib etc, where you trigger builds, which upload to Rackspace when done, and there's a final one-liner you need to run manually, to upload these wheels to PyPI. I've found that manual step is very useful, because of a) the inherent unreliability of travis, particularly, and b) the not-negligible likelihood that the builds will find a new problem, requiring further work before release.

@grlee77 grlee77 added the 🤖 type: Infrastructure CI, packaging, tools and automation label Apr 5, 2021
@scikit-image scikit-image locked and limited conversation to collaborators Oct 19, 2021
@scikit-image scikit-image unlocked this conversation Mar 30, 2022
@grlee77
Copy link
Contributor

grlee77 commented Mar 30, 2022

moved back here from discussions, but leaving closed as wheels are now built on GitHub Actions via cibuildwheel and then automatically uploaded to PyPI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 type: Infrastructure CI, packaging, tools and automation 🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

No branches or pull requests

6 participants