-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out building and uploading windows wheels to PyPI for releases #2986
Comments
Here's what appears to be a useful link: I would propose adding a twine upload step to the AppVeyor file when we tag a release. Ditto for Travis. I don't know how to manage the credentials and security though. Any suggestions? |
You're already using the Rackspace credentials to upload there, for the Linux and macOS wheels, I'd recommend doing the same for the Windows wheels. I've found it very useful to have an intermediate gathering phase before uploading, in case a later wheel build breaks, perhaps requiring a code change. I can set up the Rackspace credentials if you like, for Appveyor. Example here : https://github.com/MacPython/nipy-wheels/blob/master/appveyor.yml |
Also - did you see : scikit-image/scikit-image-wheels#3 ? |
Wheels seem to be up on pypi. I guess from scikit-image/scikit-image-wheels#6 PR. I guess we can close this? |
@hmaarrfk the current wheels were uploaded manually. Ideally, releasing skimage should be reduced to tagging the right commit on GitHub. There is much work still to do. |
Are OSX and Linux wheels uploaded automatically by travis? |
I honestly don't think you should upload the wheels automatically. At the moment, I think you have the standard process used by numpy, scipy, matplotlib etc, where you trigger builds, which upload to Rackspace when done, and there's a final one-liner you need to run manually, to upload these wheels to PyPI. I've found that manual step is very useful, because of a) the inherent unreliability of travis, particularly, and b) the not-negligible likelihood that the builds will find a new problem, requiring further work before release. |
moved back here from discussions, but leaving closed as wheels are now built on GitHub Actions via cibuildwheel and then automatically uploaded to PyPI |
Installation on windows is not easy when not using conda, see e.g. #2942 #2985. We should figure out how to build release wheels e.g. on AppVeyor so that installing on Windows is easy after release and doesn't rely on a bunch of manual work by the release manager.
The text was updated successfully, but these errors were encountered: