Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASV build matricies #3484

Closed
hmaarrfk opened this issue Oct 18, 2018 · 2 comments
Closed

ASV build matricies #3484

hmaarrfk opened this issue Oct 18, 2018 · 2 comments
Labels
🤖 type: Infrastructure CI, packaging, tools and automation 💬 Discussion 🔧 type: Maintenance Refactoring and maintenance of internals

Comments

@hmaarrfk
Copy link
Member

I think the benchmarking suite is very verbose.

"matplotlib": ["2.2"],

  • I don't think we need six anymore, but maybe when we run historical benchmarks?
  • I don't think we should pin matplotlib. Very little actually uses it.

Currently, the matrix will build 2 * 2 * 2 * 1 * 1 = 6 environments. This is a little excessive and takes a long time to build on local machines.

Is it possible to have 2 builds?

  1. A "1 year old configuration": numpy 1.14 and scipy 1.0
  2. A bleeding edge configuration. numpy 1.15 and scipy 1.1

Is this possible to configure?

pinging: @jni @TomAugspurger since they worked on getting ASV up and running
pinging: @stefanv since it seems benchmarks are being discussed in numpy as well

CC: @serge-sans-paille since he is working on pythran stuff that might benefit from this discussion

@stefanv
Copy link
Member

stefanv commented Oct 18, 2018

Yes, I imagine slowdowns are usually across platforms, so two entries seem reasonable.

@sciunto sciunto added 🔧 type: Maintenance Refactoring and maintenance of internals 💬 Discussion labels Oct 20, 2018
@grlee77 grlee77 added the 🤖 type: Infrastructure CI, packaging, tools and automation label Apr 5, 2021
@scikit-image scikit-image locked and limited conversation to collaborators Oct 18, 2021
@scikit-image scikit-image unlocked this conversation Mar 27, 2022
@grlee77
Copy link
Contributor

grlee77 commented Mar 27, 2022

closed as outdated. we only have 1 entry that gets run at the moment (Python 3.8, numpy 1.17)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 type: Infrastructure CI, packaging, tools and automation 💬 Discussion 🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

No branches or pull requests

5 participants