Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imread published wheels, consider to revert a workaround in travis? #4584

Closed
sciunto opened this issue Apr 15, 2020 · 6 comments
Closed

imread published wheels, consider to revert a workaround in travis? #4584

sciunto opened this issue Apr 15, 2020 · 6 comments

Comments

@sciunto
Copy link
Member

sciunto commented Apr 15, 2020

Description

Upstream action:
luispedro/imread#36 (comment)

Should we revert #3898?
@sciunto
Copy link
Member Author

sciunto commented Apr 15, 2020

Cc @hmaarrfk

@jni
Copy link
Member

jni commented Apr 15, 2020

I'm agnostic about this. Which translates into: if someone submits a PR and it passes, I'll approve it. =)

@sciunto sciunto mentioned this issue Apr 16, 2020
Closed
8 tasks
@hmaarrfk
Copy link
Member

I saw this, and unfortunately only wheels for linux were published.

image

I am still opposed to building imread ourselves due to the C dependencies which we at scikit-image don't have a good way to manage

@sciunto
Copy link
Member Author

sciunto commented Apr 16, 2020

OK

@sciunto sciunto closed this as completed Apr 16, 2020
@hmaarrfk
Copy link
Member

it could be fair to ask that issue to be reopened

@sciunto
Copy link
Member Author

sciunto commented Apr 16, 2020

Yes. It would rather be the issue 35 on imread's tracker

@jni jni mentioned this issue Apr 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Skip extra deps on OSX (#3898)" sciunto/scikit-image
3 participants
@hmaarrfk @sciunto @jni