Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image dtype of rank filters #466

Closed
tonysyu opened this issue Mar 15, 2013 · 0 comments · Fixed by #621
Closed

Image dtype of rank filters #466

tonysyu opened this issue Mar 15, 2013 · 0 comments · Fixed by #621

Comments

@tonysyu
Copy link
Member

tonysyu commented Mar 15, 2013

The rank filters operate on uint8 and uint16 images only. We should allow the user to pass in any dtype and convert if necessary, as suggested in the user guide.

Also, only the first 12 bits of uint16 inputs are used. Wouldn't it make sense to use the largest 12 bits instead? (That way, we could just use the output of img_as_uint.) That said, I'm not sure how to go about changing the behavior. The most obvious change would be to check for values greater than 4095 (as is done now) and do some bit-shifting if values are larger (i.e. a real uint16 value) and issue a deprecation warning if all values are smaller (i.e. a uint12 value put into uint16 array).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant