-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regionprops: rename equivalent_diameter
-> equivalent_diameter_area
#4821
Comments
Thanks @maxfrei750 ! Could you enumerate a few of the options? My impression is that this will not bring a big enough benefit to justify the API break unless we also provide others. However, when we release 1.0 we will be changing quite a few things and this might be a good candidate for that update. I’ll tag it for that. |
Admittedly, the distinction is more important for the 3d objects:
than for 2d objects:
|
@maxfrei750 so, shouldn't the renaming be |
Fixed by #5254 |
There exists actually a whole variety of equivalent diameters. Therefore, IMHO, it would be nice to have a more specific name (e.g.
equivalent_diameter_area
).The text was updated successfully, but these errors were encountered: