Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of numpy's private functions #5028

Closed
sciunto opened this issue Oct 21, 2020 · 2 comments
Closed

Remove usage of numpy's private functions #5028

sciunto opened this issue Oct 21, 2020 · 2 comments
Labels
🔰 Good first issue 🔧 type: Maintenance Refactoring and maintenance of internals

Comments

@sciunto
Copy link
Member

sciunto commented Oct 21, 2020

In skimage/util/arraycrop.py, we are using _as_pairs which belongs to numpy and is a private function.

The main issue is that the API may change at any time (and did happen). We must consider adding this code in our library.

Bonus: check if other private functions are used elsewhere (likely not).

@Harry-Kwon
Copy link
Contributor

Hi I've attempted to modify the method to remove to reference to numpy's private functions in this pull request #5081. Are these modifications ok?

I also didn't find any other uses of numpy's private functions in the codebase.

@jni
Copy link
Member

jni commented Jan 14, 2021

Closed by #5081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔰 Good first issue 🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

No branches or pull requests

3 participants