Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CI test matrix with GH Actions #5077

Closed
emmanuelle opened this issue Nov 23, 2020 · 1 comment
Closed

New CI test matrix with GH Actions #5077

emmanuelle opened this issue Nov 23, 2020 · 1 comment
Labels
🤖 type: Infrastructure CI, packaging, tools and automation

Comments

@emmanuelle
Copy link
Member

Since I'm porting our MacOS + Linux CI from Travis to Github Actions, it is a good time to reconsider whether we're happy with our matrix of test cases.

Here is the current Travis matrix

matrix:
  include:
    - os: linux
      python: 3.6
      stage: Comprehensive tests
      env: OPTIONAL_DEPS=1 WITH_PYSIDE=1 BUILD_DOCS=1 INSTALL_FROM_SDIST=1
    - os: linux
      python: 3.6
      stage: Comprehensive tests
      env: QT=PyQt5 MINIMUM_REQUIREMENTS=1
    - os: linux
      python: 3.6
      stage: Comprehensive tests
      env: PYTHONOPTIMIZE=2 BUILD_DOCS=0 TEST_EXAMPLES=0
    - os: linux
      python: 3.6
      stage: Comprehensive tests
      env: QT=PyQt5 OPTIONAL_DEPS=1 MINIMUM_REQUIREMENTS=1
    - os: linux
      python: 3.7
      stage: Comprehensive tests
      dist: xenial # Required for Python 3.7+
      env: QT=PyQt5 OPTIONAL_DEPS=1 BUILD_DOCS=1 DEPLOY_DOCS=1
      services:
        - xvfb
    - os: linux
      python: 3.7
      stage: Comprehensive tests
      # Testing and installing from sdist will ensure that tests do not
      # depend on pooch to pass
      # pooch is used as an optional dependency to download datasets on the fly
      # users installing scikit-image in development mode do not require
      # pooch to run the tests
      env: INSTALL_FROM_SDIST=1
      dist: xenial # Required for Python 3.7
      services:
        - xvfb
    - os: linux
      python: 3.7
      stage: Comprehensive tests
      dist: xenial # Required for Python 3.7
      env: QT=PyQt5 OPTIONAL_DEPS=1 BUILD_DOCS=1
      services:
        - xvfb
    - os: linux
      python: 3.8
      stage: Initial tests
      env: QT=PyQt5 OPTIONAL_DEPS=1 BUILD_DOCS=1
      dist: xenial # Required for Python 3.7+
      services:
        - xvfb
    - os: linux
      python: 3.7
      stage: Comprehensive tests
      env: QT=PyQt5 OPTIONAL_DEPS=1 PIP_FLAGS="--pre"
      dist: xenial # Required for Python 3.7
      services:
        - xvfb
    # For smooth deployment, the osx_image here should match
    # what we set in the wheel generation travis images.
    # If not set, it will use the default version from Travis
    # https://docs.travis-ci.com/user/reference/osx/#xcode-version
    - os: osx
      osx_image: xcode9.4
      language: objective-c
      stage: Comprehensive tests
      env: MB_PYTHON_VERSION=3.6 TEST_EXAMPLES=0
    - os: osx
      osx_image: xcode9.4
      language: objective-c
      stage: Comprehensive tests
      env: MB_PYTHON_VERSION=3.7 OPTIONAL_DEPS=1 EXTRA_DEPS=0
    - os: osx
      osx_image: xcode9.4
      language: objective-c
      stage: Initial tests
      env: MB_PYTHON_VERSION=3.8 OPTIONAL_DEPS=1 EXTRA_DEPS=0

DEPLOY_DOCS was not used any more, but apart from that, is there anything which I should change? For example, should the pre build run with py3.8 instead of 3.7? (There will be py3.9 to add as well, but let's first try to reproduce what we had with Travis). Should the build testing minimum requirements be on py3.7 instead of 3.6?

@jni
Copy link
Member

jni commented Nov 24, 2020

pre build run with py3.8 instead of 3.7?

I think that makes sense, and indeed, it makes sense to move it to 3.9 when the time comes.

Should the build testing minimum requirements be on py3.7 instead of 3.6?

Well, we are dropping Py3.6, so definitely!

@grlee77 grlee77 added the 🤖 type: Infrastructure CI, packaging, tools and automation label Apr 5, 2021
@scikit-image scikit-image locked and limited conversation to collaborators Oct 18, 2021
@scikit-image scikit-image unlocked this conversation Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 type: Infrastructure CI, packaging, tools and automation
Projects
None yet
Development

No branches or pull requests

4 participants