-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new illuminants for color conversion #5223
Comments
Hi @BierretA, is this something you are interested in contributing or is this just a feature request? It sounds reasonable, but I am not so familiar with the There are also some related projects like colour and `colorspacious, that provide some functionality we currently don't have. I am not sure if they have an implementation matching the issue raised here or not, though. There was some past talk in #1991 about how scikit-image could possibly port any unique functionality here to one of those and then use it here as a dependency. I don't think anyone is actively working on that at the moment, though. |
I am new to open source but I would be happy to help. If my suggestion is of interest, I can try doing a PR. Adding a few illuminants should be easy enough. |
Great, we are happy to help new contributors. You may want to wait a few days for any other feedback before starting the work. |
I'm in the same boat as @grlee77: don't know much about colorspaces, but very happy to help new contributors! 😊 The feature makes sense, I don't think there'll be much resistance from the other core devs. |
You are talking about updating/adding to the illuminants and observers for CIE color spaces? That sounds like a nice addition :) I just skimmed the codebase, and I think it looks like a good first issue. I wonder if it is worthwhile to add to that a general implementation that allows a user to manually specify the observer and illuminant while keeping the option to have common ones pre-specified. |
For now, I will try a simple PR to add a few illuminants/observers. |
Description
For users of the R programming language, color space conversions can be performed using the standard function grDevices::convertColor, which is part of R-core.
The white points for this function are:
White points B and C are not implemented in skimage.
D50, D55 and D65 white points in R do not match the XYZ coordinates of the illuminants in skimage colorconv.py.
Adding "B" and "C" white points and adding "R" as a new observer for the "D50", "D55" and "D65" illuminants would improve compatibilty with color conversions performed in R.
The text was updated successfully, but these errors were encountered: