Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rolling ball example for ECG data #5255

Closed
grlee77 opened this issue Mar 1, 2021 · 3 comments · Fixed by #5412
Closed

Add rolling ball example for ECG data #5255

grlee77 opened this issue Mar 1, 2021 · 3 comments · Fixed by #5412
Labels
🔰 Good first issue 📄 type: Documentation Updates, fixes and additions to documentation

Comments

@grlee77
Copy link
Contributor

grlee77 commented Mar 1, 2021

Description

The demo I made for this response in the PyWavelets google group would be nice to include in our gallery to show that the "n-dimensional" implementation of rolling ball allows application to signals as well:
https://groups.google.com/g/pywavelets/c/b3ErI_GmNBo

Fortunately, the short ECG waveform used for the example there is already bundled by PyWavelets.

@grlee77 grlee77 added the 📄 type: Documentation Updates, fixes and additions to documentation label Mar 1, 2021
@sebgoti
Copy link
Contributor

sebgoti commented May 26, 2021

Hello :) May I take this issue?

@grlee77
Copy link
Contributor Author

grlee77 commented May 26, 2021

sure, that would be great! Please let us know if you need help/guidance. The current rolling ball example is located at doc/examples/segmentation/plot_rolling_ball.py. I think it may make sense to extend that one, but another possibility is making a new file.

@sebgoti
Copy link
Contributor

sebgoti commented May 31, 2021

sure, that would be great! Please let us know if you need help/guidance. The current rolling ball example is located at doc/examples/segmentation/plot_rolling_ball.py. I think it may make sense to extend that one, but another possibility is making a new file.

Thanks @grlee77, this is my first contribution and I followed all the guidelines, I hope everything is in order but please let me know about any errors. I wanted to ask you about an idea I had to extend the rolling ball example by creating a short animation of a circle rolling on the ECG data while generating the background output. I thought that it might be a good visualization to understand better the whole rolling ball concept. Cheers, Sebastian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔰 Good first issue 📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants