Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken doctests (doctests not being run on CI) #5502

Closed
grlee77 opened this issue Aug 5, 2021 · 4 comments
Closed

Broken doctests (doctests not being run on CI) #5502

grlee77 opened this issue Aug 5, 2021 · 4 comments
Assignees
Labels
🤖 type: Infrastructure CI, packaging, tools and automation

Comments

@grlee77
Copy link
Contributor

grlee77 commented Aug 5, 2021

Description

In #5361 (comment) it was pointed out that the profile_line examples list incorrect outputs. Are we no longer running doctests on any CI job? I know that our unit tests are greatly preferable to doctests for testing purposes, but we should still be verifying that the given examples run as expected.

@grlee77
Copy link
Contributor Author

grlee77 commented Aug 6, 2021

The older tools/travis/before_install.sh TravisCI scripts set the option to run the doctests and tools/travis/script.sh used this when calling pytest.

tools/travis/before_install.sh:export TEST_ARGS="--doctest-modules --cov=skimage"
tools/travis/script.sh:(cd .. && pytest $TEST_ARGS --pyargs skimage)

The newer GHA tools/github/before_install.sh also sets this TEST_ARGS environment variable , but it does not seem to be used when calling pytest in any of the .github/workflows files and it is also used in tools/github/script.sh. I will have to inspect the CI logs to see if it shows up there

@grlee77
Copy link
Contributor Author

grlee77 commented Aug 6, 2021

I will open a PR to add this to the GHA workflow and fix any existing doctest failures that may have crept in.

@grlee77
Copy link
Contributor Author

grlee77 commented Aug 6, 2021

The underlying issue was that environment variables do not persist between GitHub Actions steps. There is a fix for this in #5505

@grlee77
Copy link
Contributor Author

grlee77 commented Aug 25, 2021

closed by #5505

@grlee77 grlee77 closed this as completed Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 type: Infrastructure CI, packaging, tools and automation
Projects
None yet
Development

No branches or pull requests

1 participant