Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request that PR #5249 be included in next 0.18.x patch release #5562

Closed
erykoff opened this issue Sep 10, 2021 · 13 comments
Closed

Request that PR #5249 be included in next 0.18.x patch release #5562

erykoff opened this issue Sep 10, 2021 · 13 comments

Comments

@erykoff
Copy link
Contributor

erykoff commented Sep 10, 2021

Description

The Rubin Observatory science pipelines is pinned on scikit-image<0.18 because 0.18.x doesn't run when installed on read-only filesystems (as is one of our distribution methods). This was fixed in #5249 . I was hoping that this could be backported to 0.18.x for the next minor release.

@mkcor
Copy link
Member

mkcor commented Sep 10, 2021

ping @hmaarrfk

@hmaarrfk
Copy link
Member

I think that #5564 should be ready to go. I think I found the source of the failing tests and am more confident about it.

I'm not super sure I will have time to go through the motions of a release.

But hopefully that should help others release.

@erykoff
Copy link
Contributor Author

erykoff commented Sep 13, 2021

Thank you!

@hmaarrfk
Copy link
Member

do you use conda by any chance? once the PR makes it through, i might be able to release it there on conda-forge faster

@hmaarrfk
Copy link
Member

othwr solutions might involve settinf an enviornment variable. or uninstalling pooch.

let eme know if those work for you then i can help craft them.

@erykoff
Copy link
Contributor Author

erykoff commented Sep 13, 2021

We use conda-forge for distributing our third-party environment, yes. Getting it there would be ideal. Thanks!

I believe we tried other workarounds, and #5249 was the most straightforward.

@hmaarrfk
Copy link
Member

Ok. I'll release a conda-forge patch as soon as the PR makes it through.

@hmaarrfk
Copy link
Member

Or rather, I"ll make the PR to the conda-forge repo to let others review it and give their input on if we should release a conda-forge fix before a pypi fix.

@rfezzani
Copy link
Member

Any update on this issue @hmaarrfk and @erykoff ? Can we close it?

@hmaarrfk
Copy link
Member

The PR has been merged.

The release process kinda scares me, so I haven't had a chance to go through it yet.

@erykoff
Copy link
Contributor Author

erykoff commented Oct 20, 2021

Please let me know if there's anything I can do to help. We're hoping to have this cleared up soon so we can make our next release without the pin. Thanks!

@hmaarrfk
Copy link
Member

I think likely the best thing will be to use != pins instead of == pins.

It will be included in whatever the next release is, whether it is 0.19 or 0.18.4 so hopefully that helps you in packaging.

@hmaarrfk
Copy link
Member

hmaarrfk commented Dec 3, 2021

Since 0.19.0 just got released, I'm going to close this issue. I'm sorry this took so long to get fixed. Hopefully you should be able to use the pypi package or the soon to be released conda package on conda-forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants