-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request that PR #5249 be included in next 0.18.x patch release #5562
Comments
ping @hmaarrfk |
I think that #5564 should be ready to go. I think I found the source of the failing tests and am more confident about it. I'm not super sure I will have time to go through the motions of a release. But hopefully that should help others release. |
Thank you! |
do you use conda by any chance? once the PR makes it through, i might be able to release it there on conda-forge faster |
othwr solutions might involve settinf an enviornment variable. or uninstalling pooch. let eme know if those work for you then i can help craft them. |
We use conda-forge for distributing our third-party environment, yes. Getting it there would be ideal. Thanks! I believe we tried other workarounds, and #5249 was the most straightforward. |
Ok. I'll release a conda-forge patch as soon as the PR makes it through. |
Or rather, I"ll make the PR to the conda-forge repo to let others review it and give their input on if we should release a conda-forge fix before a pypi fix. |
The PR has been merged. The release process kinda scares me, so I haven't had a chance to go through it yet. |
Please let me know if there's anything I can do to help. We're hoping to have this cleared up soon so we can make our next release without the pin. Thanks! |
I think likely the best thing will be to use It will be included in whatever the next release is, whether it is 0.19 or 0.18.4 so hopefully that helps you in packaging. |
Since 0.19.0 just got released, I'm going to close this issue. I'm sorry this took so long to get fixed. Hopefully you should be able to use the pypi package or the soon to be released conda package on conda-forge. |
Description
The Rubin Observatory science pipelines is pinned on scikit-image<0.18 because 0.18.x doesn't run when installed on read-only filesystems (as is one of our distribution methods). This was fixed in #5249 . I was hoping that this could be backported to 0.18.x for the next minor release.
The text was updated successfully, but these errors were encountered: