Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for metrics #330

Closed
LacombeLouis opened this issue Jul 26, 2023 · 2 comments · Fixed by #358
Closed

Add checks for metrics #330

LacombeLouis opened this issue Jul 26, 2023 · 2 comments · Fixed by #358
Assignees
Labels
developers Proposed by developers. good first issue Good for newcomers
Milestone

Comments

@LacombeLouis
Copy link
Collaborator

Would be good to add additional checks for the metrics.
For example:

  • check that y_true and y_pred are the same length
  • check that there are no Nans

Simple check to assure that the user has good feedback upon error in metric.

@LacombeLouis LacombeLouis added the good first issue Good for newcomers label Jul 26, 2023
@thibaultcordier thibaultcordier added this to Need triage in Developments via automation Jul 26, 2023
@thibaultcordier thibaultcordier added the developers Proposed by developers. label Aug 3, 2023
@LacombeLouis LacombeLouis modified the milestones: Release 0.8.0, Backlog H2 2023, Release 0.7.0 Aug 3, 2023
@LacombeLouis LacombeLouis added this to H2 2023 in Roadmap Aug 3, 2023
@LacombeLouis LacombeLouis modified the milestones: Backlog H2 2023, Release 0.8.0 Aug 3, 2023
@JumpingDino
Copy link
Contributor

JumpingDino commented Sep 11, 2023

Is it okay if I try to do this one?

I expect to create two functions

  • check_array_length
  • check_array_nan

which will try to make these checks for the metrics inside metrics.py

@thibaultcordier
Copy link
Collaborator

Hello @JumpingDino, that's a good suggestion for solving this issue, thank you.
You can fork the repositoty (see CONTRIBUTING.rst) and propose a pull request with these functions in the mapie/utils.py file and their corresponding tests. Don't hesitate to ask for help during implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developers Proposed by developers. good first issue Good for newcomers
Projects
Roadmap
H2 2023
Development

Successfully merging a pull request may close this issue.

3 participants