Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoherent sign on C_k in the Kolmogorov-Smirnov statistical test documentation #369

Closed
JulienRoussel77 opened this issue Oct 31, 2023 · 2 comments · Fixed by #470
Closed
Labels
developers Proposed by developers. documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@JulienRoussel77
Copy link
Collaborator

JulienRoussel77 commented Oct 31, 2023

The formula for C_k presented here has a sign convention that is the opposite of the implementation in the function mapie.metrics.kolmogorov_smirnov_statistic : link

@JulienRoussel77 JulienRoussel77 added the documentation Improvements or additions to documentation label Oct 31, 2023
@thibaultcordier thibaultcordier added the developers Proposed by developers. label Dec 11, 2023
@LacombeLouis LacombeLouis added the good first issue Good for newcomers label Jun 19, 2024
@BaptisteCalot
Copy link
Collaborator

I seems to be good and the code matches the documentation

1- Here is the code

2- Here is the doc

@LacombeLouis can you confirm my observation please ?

@BaptisteCalot BaptisteCalot changed the title Incoherent sign on mapie.metrics.cumulative_differences Incoherent sign on C_k in the Kolmogorov-Smirnov statistical test documentation Jun 25, 2024
@BaptisteCalot
Copy link
Collaborator

BaptisteCalot commented Jun 25, 2024

I have changed the title of the issue as well as its description: the sign error into C_k (cumulative difference) comes from its use into the Kolmogorov-Smirnov statistical test, not from the cumulative difference metric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developers Proposed by developers. documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
Status: Done
4 participants