UPD: change configuration project #363
Conversation
thibaultcordier
added
enhancement
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
| - sphinx=4.3.2 | ||
| - sphinx-gallery=0.10.1 | ||
| - sphinx_rtd_theme=1.0.0 | ||
| - typing_extensions=4.0.1 | ||
| - pandas |
There was a problem hiding this comment.
why did you remove the versions ?
There was a problem hiding this comment.
because there's no incompatibility with the latest version of pandas so far. so there's no reason to constrain the version
There was a problem hiding this comment.
I still feel like we should force a version. We don't want the doc not building for a version problem. (we can perform version updates every now and then?)
|
|
||
| zeros_scores_proba_last = (y_pred_proba_last <= EPSILON) | ||
| zeros_scores_proba_last = y_pred_proba_last <= EPSILON |
There was a problem hiding this comment.
this line is easier to understand with the '()'
| ).filled(fill_value=np.inf), | ||
| axis=1 | ||
| ), axis=1 | ||
| np.min(np.ma.masked_less(y_pred_proba, EPSILON).filled(fill_value=np.inf), axis=1), |
There was a problem hiding this comment.
An example where I think it's less readable after black : here you have 4 numpy functions in 3 lines (expand_dims, min, masked_less, filled), quite hard to understand
There was a problem hiding this comment.
In this case, I should have added pre-commit first, then thought about black.
There was a problem hiding this comment.
Generally a very clean, good update. Thank you @thibaultcordier.
I think black has some disadvantages, but mainly, it will help clean up the code more than it will make it less readable.
I do wonder whether we should perform the linting before black or not. Please checkout comment.
| - sphinx=4.3.2 | ||
| - sphinx-gallery=0.10.1 | ||
| - sphinx_rtd_theme=1.0.0 | ||
| - typing_extensions=4.0.1 | ||
| - pandas |
There was a problem hiding this comment.
I still feel like we should force a version. We don't want the doc not building for a version problem. (we can perform version updates every now and then?)
| np.random.multivariate_normal(center, cov, n_samples) | ||
| for center, cov in zip(centers, covs) | ||
| ] | ||
| [np.random.multivariate_normal(center, cov, n_samples) for center, cov in zip(centers, covs)] |
There was a problem hiding this comment.
I don't think this is very code reading friendly. Is this black?
There was a problem hiding this comment.
Yes, this is black
There was a problem hiding this comment.
Ugh, sometimes, black is really not friendly. 😆
| @@ -1,7 +1,10 @@ | |||
| codecov | |||
| flake8 | |||
| flake8==4.0.1 | |||
There was a problem hiding this comment.
[question]
What is the usage of the requirements files when we have environment ones?
There was a problem hiding this comment.
This allows the user to choose whether to install with pip or conda.
Description
This configures the pre-commit functionnality: when you prepare a commit, it will automatically run default pre-commit checks and run black and flake8 checks.
Fixes #(issue)
Type of change
Checklist
make lintmake type-checkmake testsmake coveragemake doc