Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

416 update from developers #417

Closed
wants to merge 4 commits into from
Closed

416 update from developers #417

wants to merge 4 commits into from

Conversation

LacombeLouis
Copy link
Collaborator

@LacombeLouis LacombeLouis commented Mar 1, 2024 •
edited

Description

Fix issues from #416 and sort the imports.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@LacombeLouis LacombeLouis self-assigned this Mar 1, 2024
@LacombeLouis LacombeLouis linked an issue Mar 1, 2024 that may be closed by this pull request
Update from developers #416
Closed
thibaultcordier
thibaultcordier requested changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@thibaultcordier thibaultcordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is relevant for making the code understandable. But I suggest you make two separate PRs (the simplest would be to put the contributors' emails in another PR and rename the current PR).

@LacombeLouis LacombeLouis deleted the 416-update-from-developers branch March 1, 2024 13:38
@LacombeLouis LacombeLouis removed a link to an issue Mar 1, 2024
Update from developers #416
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaultcordier thibaultcordier thibaultcordier requested changes

Assignees

@LacombeLouis LacombeLouis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LacombeLouis @thibaultcordier