Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building of Ensemble Classifier from MapieClassifier #445

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Building of Ensemble Classifier from MapieClassifier #445

wants to merge 25 commits into from

Conversation

BaptisteCalot
Copy link
Collaborator

@BaptisteCalot BaptisteCalot commented May 15, 2024 •
edited by thibaultcordier

Description

  • Migration of some code from classification.py into estimator_classifier.py
  • Adapt unit tests

Fixes #430

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Adapt existing unit tests to the new class and check that everything still works.

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentblot28 vincentblot28 Awaiting requested review from vincentblot28

@thibaultcordier thibaultcordier Awaiting requested review from thibaultcordier

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH : Build an Ensemble classifier based on regression refactoring
3 participants
@BaptisteCalot @thibaultcordier @vincentblot28