Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix userwarning unittests #171

Merged

Conversation

datarian
Copy link

Fixes unit tests that test for a UserWarning. See discussion in #169.

Now handled with:

self.assertWarns(UserWarning, msg="WarningMessage")
    function(x)

Some tests still fail because this branch does not contain the fix for helpers.verify_numeric() proposed in #170. After that PR is merged in, all tests should pass.

florian and others added 8 commits March 19, 2019 12:19
Changed setting feature names slightly
as instance variables.
-> Necessary for it to work in an sklearn.ColumnTransformer!
if handle_missing = return_nan set nan_identity = -2?
@janmotl janmotl merged commit e6cdd52 into scikit-learn-contrib:master Mar 21, 2019
@datarian datarian deleted the fix-userwarning-unittests branch March 21, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants